CareerCup

My Answer is that in this do-while loop will go in indefinite loop as value of 'i' is not getting increment in case when 'a' or 'A' is encountered.. you guys can you figure out some other bugs ???

tmpvar is of type int while len is unsigned long. If parameter > 2^31 is passed it will be a problem.

Also tmpvar is unnecessary.

The check of *pch==NULL etc is wrong. The correct check would be if pch==NULL

1)
if(pch[i]=='A' || pch[i]=='a')
ret++
else
/* there should not be this else, because we have increase the index anyhow to check the next character*/
i++

2) also tmpvar is int and len in unsigned long.. might cause problem

Also in the line
f(*pch==NULL || !strcmp(pch," "))

the "!" should not be there for the strcmp() check because, we should return 0 if pch is an empty space.

Guys I see one more bug

if(*pch==NULL || !strcmp(pch," "))
would return true if there is a sapce found in the input string and program will terminate.
Thus this program would not work for multi-word string.

it accept a string, but the pointer pch pointed to char.
if(*pch==NULL || !strcmp(pch," ")) instead of take off the first*, I think should add the second*...
It should be if(*pch==NULL || strcmp(*pch," "))